Page MenuHomePhabricator

Correctly identify symbols in `n_CLASS_STATIC_ACCESS`
ClosedPublic

Authored by joshuaspence on Jan 2 2015, 1:03 AM.
Tags
None
Referenced Files
F15411364: D11137.id26744.diff
Wed, Mar 19, 9:13 AM
F15409654: D11137.id.diff
Wed, Mar 19, 4:49 AM
F15408033: D11137.diff
Tue, Mar 18, 9:00 PM
F15396342: D11137.id26747.diff
Sun, Mar 16, 1:38 PM
Unknown Object (File)
Fri, Feb 28, 5:34 PM
Unknown Object (File)
Tue, Feb 18, 2:39 PM
Unknown Object (File)
Feb 8 2025, 12:37 AM
Unknown Object (File)
Feb 8 2025, 12:37 AM
Subscribers

Details

Summary

Fixes T6847. These symbols should always be classes, as interfaces cannot have methods defined.

Test Plan
test.php
<?php

Foo::bar();
> ./scripts/phutil_symbols.php test.php
{
  "have": [],
  "need": {
    "class": {
      "Foo": 7
    }
  },
  "xmap": []
}

(We should really have some test cases defined for this file)

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3473
Build 3480: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Correctly label symbols in `n_CLASS_STATIC_ACCESS`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence retitled this revision from Correctly label symbols in `n_CLASS_STATIC_ACCESS` to Correctly identify symbols in `n_CLASS_STATIC_ACCESS`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 1:41 AM
This revision was automatically updated to reflect the committed changes.