Page MenuHomePhabricator

Correctly identify symbols in `n_CLASS_STATIC_ACCESS`
ClosedPublic

Authored by joshuaspence on Jan 2 2015, 1:03 AM.
Tags
None
Referenced Files
F19063531: D11137.diff
Sat, Nov 29, 7:09 PM
F19057570: D11137.id26744.diff
Fri, Nov 28, 11:10 PM
F18944652: D11137.diff
Nov 11 2025, 4:39 PM
F18844196: D11137.id.diff
Oct 29 2025, 3:54 AM
F18842872: D11137.diff
Oct 28 2025, 7:15 PM
F18815766: D11137.diff
Oct 21 2025, 3:36 AM
F18765467: D11137.diff
Oct 7 2025, 11:29 AM
F18743938: D11137.id26747.diff
Oct 3 2025, 1:21 AM
Subscribers

Details

Summary

Fixes T6847. These symbols should always be classes, as interfaces cannot have methods defined.

Test Plan
test.php
<?php

Foo::bar();
> ./scripts/phutil_symbols.php test.php
{
  "have": [],
  "need": {
    "class": {
      "Foo": 7
    }
  },
  "xmap": []
}

(We should really have some test cases defined for this file)

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3473
Build 3480: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Correctly label symbols in `n_CLASS_STATIC_ACCESS`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence retitled this revision from Correctly label symbols in `n_CLASS_STATIC_ACCESS` to Correctly identify symbols in `n_CLASS_STATIC_ACCESS`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 1:41 AM
This revision was automatically updated to reflect the committed changes.