Page MenuHomePhabricator

Correctly identify symbols in `n_CLASS_STATIC_ACCESS`
ClosedPublic

Authored by joshuaspence on Jan 2 2015, 1:03 AM.
Tags
None
Referenced Files
F18242214: D11137.id.diff
Thu, Aug 21, 3:58 AM
F18234758: D11137.diff
Wed, Aug 20, 6:33 PM
F18041466: D11137.id.diff
Sun, Aug 3, 4:33 AM
Unknown Object (File)
Jul 3 2025, 1:54 PM
Unknown Object (File)
May 21 2025, 3:28 AM
Unknown Object (File)
May 8 2025, 11:31 AM
Unknown Object (File)
May 7 2025, 4:48 AM
Unknown Object (File)
Apr 25 2025, 12:14 PM
Subscribers

Details

Summary

Fixes T6847. These symbols should always be classes, as interfaces cannot have methods defined.

Test Plan
test.php
<?php

Foo::bar();
> ./scripts/phutil_symbols.php test.php
{
  "have": [],
  "need": {
    "class": {
      "Foo": 7
    }
  },
  "xmap": []
}

(We should really have some test cases defined for this file)

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3473
Build 3480: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Correctly label symbols in `n_CLASS_STATIC_ACCESS`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence retitled this revision from Correctly label symbols in `n_CLASS_STATIC_ACCESS` to Correctly identify symbols in `n_CLASS_STATIC_ACCESS`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 1:41 AM
This revision was automatically updated to reflect the committed changes.