Page MenuHomePhabricator
Differential D11114

Modernize Dashboard edges
ClosedPublic
Actions

Authored by joshuaspence on Jan 1 2015, 4:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 10:52 AM
Unknown Object (File)
Sat, Dec 21, 7:55 AM
Unknown Object (File)
Wed, Dec 11, 7:04 AM
Unknown Object (File)
Sat, Dec 7, 11:19 AM
Unknown Object (File)
Nov 30 2024, 1:04 AM
Unknown Object (File)
Nov 28 2024, 7:23 AM
Unknown Object (File)
Nov 26 2024, 10:37 PM
Unknown Object (File)
Nov 26 2024, 7:27 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP44ec1d737446: Modernize Dashboard edges
Summary

Modernize Dashboard edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan

Attached a panel to a dashboard, observed the expected comment in the transaction view (both ways).

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3438
Build 3445: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26689.Jan 1 2015, 4:51 AM
joshuaspence retitled this revision from to Modernize Dashboard edges.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 1 2015, 4:51 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 26691.Jan 1 2015, 5:48 AM
joshuaspence edited edge metadata.

Fix some stuff

joshuaspence updated this object.Jan 1 2015, 5:49 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a parent revision: D11113: Modernize Pholio edges.Jan 1 2015, 12:33 PM
epriestley accepted this revision.Jan 1 2015, 2:37 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Jan 1 2015, 2:37 PM
Closed by commit rP44ec1d737446: Modernize Dashboard edges (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 1 2015, 11:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26689

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardCopyController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardEditController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardRemovePanelController.php

Loading...
View Options

src/applications/dashboard/edge/PhabricatorDashboardDashboardHasPanelEdgeType.php

Loading...
View Options

src/applications/dashboard/edge/PhabricatorDashboardPanelHasDashboardEdgeType.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardQuery.php

Loading...
View Options

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

Loading...
Phabricator · Built by Phacility