Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5549: Add "Editable by" policy setting to Paste
- Commits
- Restricted Diffusion Commit
rPa84cd9989398: Paste: Add edit policy
Set edit policy on paste, check that only users meeting the policy requirements can edit it.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T5549
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3409 Build 3416: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Couple of minor things inline, this looks great overall. Thanks!
| resources/sql/autopatches/20141230.pasteeditpolicycolumn.sql | ||
|---|---|---|
| 2 | This should be NOT NULL for consistency with other policy columns. | |
| resources/sql/autopatches/20141230.pasteeditpolicyexisting.sql | ||
| 2 | Since the column will be NOT NULL, this should be WHERE editPolicy = ''. | |
| src/applications/paste/capability/PasteDefaultEditCapability.php | ||
| 11–13 | Remove this; public edits aren't supported (principally, we don't have a user to attribute the edit to). | |
| src/applications/paste/storage/PhabricatorPaste.php | ||
| 58 | Yeah, just make this policy (which should be the default, so you can omit it). The policy? spec on viewPolicy is an error that we just haven't cleaned up yet (see T6203). | |