Page MenuHomePhabricator

Use better variable names
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 5:35 PM
Unknown Object (File)
Sun, Feb 23, 5:26 AM
Unknown Object (File)
Mon, Feb 17, 2:51 AM
Unknown Object (File)
Thu, Feb 13, 1:01 PM
Unknown Object (File)
Sat, Feb 8, 11:29 PM
Unknown Object (File)
Sat, Feb 8, 12:28 AM
Unknown Object (File)
Sat, Feb 8, 12:28 AM
Unknown Object (File)
Sat, Feb 8, 12:28 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP02b2883555c6: Use better variable names
Summary

Use p and c instead of (reusing) k. This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/projects/behavior-project-boards.js:

   Warning  (W004) JSHintW004
    'k' is already defined.

              57       'phui-tag-shade-blue': (sum > 0 && !over_limit),
              58       'phui-tag-shade-red': (over_limit)
              59     };
    >>>       60     for (var k in color_map) {
              61       JX.DOM.alterClass(data.countTagNode, k, !!color_map[k]);
              62     }
              63   }
Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Use better variable names.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:56 AM
This revision was automatically updated to reflect the committed changes.