Page MenuHomePhabricator

Use `window.confirm` instead of `confirm`
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:17 AM.
Tags
None
Referenced Files
F15466126: D11065.diff
Thu, Apr 3, 1:51 AM
F15460929: D11065.diff
Tue, Apr 1, 3:29 AM
F15456063: D11065.diff
Sun, Mar 30, 6:48 AM
F15434712: D11065.id26578.diff
Tue, Mar 25, 4:57 AM
F15429907: D11065.id26558.diff
Mon, Mar 24, 4:50 AM
F15429593: D11065.id26558.diff
Mon, Mar 24, 3:04 AM
F15429529: D11065.diff
Mon, Mar 24, 2:50 AM
F15415863: D11065.id26578.diff
Thu, Mar 20, 8:00 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP5251f08fb432: Use `window.confirm` instead of `confirm`
Summary

This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js:

   Warning  (W117) JSHintW117
    'confirm' is not defined.

              39           notification.listen(
              40             'activate',
              41             function() {
    >>>       42               if (!confirm('Close notification?')) {
              43                 JX.Stratcom.context().kill();
              44               }
              45             });
Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Use `window.confirm` instead of `confirm`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:53 AM
This revision was automatically updated to reflect the committed changes.