Page MenuHomePhabricator

Use `window.confirm` instead of `confirm`
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 22 2024, 5:41 PM
Unknown Object (File)
Oct 19 2024, 10:37 AM
Unknown Object (File)
Oct 2 2024, 11:45 PM
Unknown Object (File)
Oct 2 2024, 8:59 AM
Unknown Object (File)
Sep 19 2024, 11:38 PM
Unknown Object (File)
Sep 19 2024, 8:11 PM
Unknown Object (File)
Sep 16 2024, 10:38 PM
Unknown Object (File)
Sep 13 2024, 7:45 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP5251f08fb432: Use `window.confirm` instead of `confirm`
Summary

This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js:

   Warning  (W117) JSHintW117
    'confirm' is not defined.

              39           notification.listen(
              40             'activate',
              41             function() {
    >>>       42               if (!confirm('Close notification?')) {
              43                 JX.Stratcom.context().kill();
              44               }
              45             });
Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3360
Build 3367: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Use `window.confirm` instead of `confirm`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:53 AM
This revision was automatically updated to reflect the committed changes.