Page MenuHomePhabricator
Differential D11071

Define a seperate JSHint configuration for NodeJS files
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:37 AM.
Tags
None
Referenced Files
F15168818: D11071.id.diff
Tue, Feb 18, 11:45 PM
Unknown Object (File)
Sun, Feb 16, 9:20 PM
Unknown Object (File)
Sun, Feb 16, 6:35 PM
Unknown Object (File)
Sat, Feb 15, 1:19 AM
Unknown Object (File)
Wed, Feb 12, 9:57 PM
Unknown Object (File)
Wed, Feb 12, 9:33 PM
Unknown Object (File)
Wed, Feb 12, 9:16 PM
Unknown Object (File)
Wed, Feb 12, 9:06 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPb6e0c76c7d6b: Define a seperate JSHint configuration for NodeJS files
Summary

Currently, we assume that all JavaScript files are for use in a browser. This is not true for the NodeJS Aphlict server code. Split the current JSHint configuration into jshint-browser and jshint-node.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3367
Build 3374: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26564.Dec 30 2014, 10:37 AM
joshuaspence retitled this revision from to Define a seperate JSHint configuration for NodeJS files.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:37 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 26565.Dec 30 2014, 10:39 AM
joshuaspence edited edge metadata.

Fix paths

epriestley accepted this revision.Dec 30 2014, 10:59 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:59 AM
epriestley requested changes to this revision.Dec 30 2014, 11:01 AM
epriestley edited edge metadata.

This interacted with D11069, yell if I got the merge wrong.

This revision now requires changes to proceed.Dec 30 2014, 11:01 AM
epriestley accepted this revision.Dec 30 2014, 11:01 AM
epriestley edited edge metadata.

Whoops, didn't mean to request changes.

This revision is now accepted and ready to land.Dec 30 2014, 11:01 AM
Closed by commit rPb6e0c76c7d6b: Define a seperate JSHint configuration for NodeJS files (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 11:02 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a comment.Dec 30 2014, 11:04 AM

LGTM. I could've landed it myself (unless you've changed your policies lately I guess).

Revision Contents
Changeset List

PathSize
14 lines
support/
lint/
22 lines
2 lines

Diff 26565

View Options

.arclint

Loading...
View Options

support/lint/browser.jshintrc

Loading...
View Options

support/lint/jshintrc

Loading...
View Options

support/lint/node.jshintrc

Loading...
Phabricator · Built by Phacility