Page MenuHomePhabricator

Define a seperate JSHint configuration for NodeJS files
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:37 AM.
Tags
None
Referenced Files
F15392187: D11071.id26584.diff
Sat, Mar 15, 1:41 PM
F15391444: D11071.id26584.diff
Sat, Mar 15, 9:54 AM
F15384194: D11071.diff
Fri, Mar 14, 7:06 PM
Unknown Object (File)
Fri, Feb 21, 6:19 AM
Unknown Object (File)
Thu, Feb 20, 10:51 PM
Unknown Object (File)
Tue, Feb 18, 11:45 PM
Unknown Object (File)
Feb 16 2025, 9:20 PM
Unknown Object (File)
Feb 16 2025, 6:35 PM
Subscribers

Details

Summary

Currently, we assume that all JavaScript files are for use in a browser. This is not true for the NodeJS Aphlict server code. Split the current JSHint configuration into jshint-browser and jshint-node.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3366
Build 3373: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Define a seperate JSHint configuration for NodeJS files.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:59 AM
epriestley edited edge metadata.

This interacted with D11069, yell if I got the merge wrong.

This revision now requires changes to proceed.Dec 30 2014, 11:01 AM
epriestley edited edge metadata.

Whoops, didn't mean to request changes.

This revision is now accepted and ready to land.Dec 30 2014, 11:01 AM
This revision was automatically updated to reflect the committed changes.

LGTM. I could've landed it myself (unless you've changed your policies lately I guess).