Page MenuHomePhabricator

Use better variable names
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 11:43 AM
Unknown Object (File)
Fri, Nov 15, 12:46 PM
Unknown Object (File)
Mon, Nov 11, 3:45 AM
Unknown Object (File)
Wed, Nov 6, 9:53 PM
Unknown Object (File)
Tue, Nov 5, 3:43 AM
Unknown Object (File)
Oct 23 2024, 7:38 PM
Unknown Object (File)
Oct 20 2024, 10:00 AM
Unknown Object (File)
Oct 19 2024, 5:34 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP02b2883555c6: Use better variable names
Summary

Use p and c instead of (reusing) k. This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/projects/behavior-project-boards.js:

   Warning  (W004) JSHintW004
    'k' is already defined.

              57       'phui-tag-shade-blue': (sum > 0 && !over_limit),
              58       'phui-tag-shade-red': (over_limit)
              59     };
    >>>       60     for (var k in color_map) {
              61       JX.DOM.alterClass(data.countTagNode, k, !!color_map[k]);
              62     }
              63   }
Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3361
Build 3368: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Use better variable names.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:56 AM
This revision was automatically updated to reflect the committed changes.