Page MenuHomePhabricator

Use `window.confirm` instead of `confirm`
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:17 AM.
Tags
None
Referenced Files
F15415863: D11065.id26578.diff
Thu, Mar 20, 8:00 AM
F15412012: D11065.id26578.diff
Wed, Mar 19, 10:50 AM
F15388294: D11065.id26558.diff
Sat, Mar 15, 3:36 AM
F15386298: D11065.id26578.diff
Sat, Mar 15, 12:19 AM
F15381588: D11065.id26578.diff
Fri, Mar 14, 8:30 AM
F15374996: D11065.id26558.diff
Wed, Mar 12, 9:00 PM
F15333971: D11065.id26578.diff
Sat, Mar 8, 6:03 AM
Unknown Object (File)
Tue, Feb 25, 3:55 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP5251f08fb432: Use `window.confirm` instead of `confirm`
Summary

This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js:

   Warning  (W117) JSHintW117
    'confirm' is not defined.

              39           notification.listen(
              40             'activate',
              41             function() {
    >>>       42               if (!confirm('Close notification?')) {
              43                 JX.Stratcom.context().kill();
              44               }
              45             });
Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3360
Build 3367: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Use `window.confirm` instead of `confirm`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:53 AM
This revision was automatically updated to reflect the committed changes.