Page MenuHomePhabricator
Differential D10988

Support simpler, token-based Conduit authentication in Arcanist
ClosedPublic
Actions

Authored by epriestley on Dec 13 2014, 12:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 5:46 AM
Unknown Object (File)
Thu, Dec 19, 5:24 PM
Unknown Object (File)
Thu, Dec 19, 1:26 PM
Unknown Object (File)
Thu, Dec 19, 1:26 PM
Unknown Object (File)
Thu, Dec 19, 1:25 PM
Unknown Object (File)
Fri, Dec 13, 2:27 AM
Unknown Object (File)
Thu, Dec 5, 2:00 PM
Unknown Object (File)
Nov 24 2024, 9:49 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings
Commits
rARC511898775788: Support simpler, token-based Conduit authentication in Arcanist
Summary

Ref T5955. If the server supports token-based authentication, prefer it over certificate-based authentication.

Also fixes T3117.

Test Plan
  • Used arc install-certificate to install credentials from both token-based and certificate-based hosts.
  • Used arc list with a token-based host.

Diff Detail

Repository
rARC Arcanist
Branch
tauth
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3257
Build 3263: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26381.Dec 13 2014, 12:31 AM
epriestley retitled this revision from to Support simpler, token-based Conduit authentication in Arcanist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Herald added a subscriber: epriestley. · View Herald TranscriptDec 13 2014, 12:31 AM
epriestley updated this revision to Diff 26382.Dec 13 2014, 12:40 AM
epriestley added a task: Restricted Maniphest Task.
  • Fixes T2878. Remove the horrifically deceptive URI from the "you need to authenticate" message.
epriestley mentioned this in D10989: Add conduit.getcapabilities and a modern CLI handshake workflow.Dec 13 2014, 12:45 AM
epriestley updated this object.Dec 13 2014, 6:21 PM
epriestley added a task: Restricted Maniphest Task.
btrahan accepted this revision.Dec 15 2014, 6:46 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2014, 6:46 PM
Closed by commit rARC511898775788: Support simpler, token-based Conduit authentication in Arcanist (authored by epriestley, committed by epriestley). · Explain WhyDec 15 2014, 7:12 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP288498f8d099: Add conduit.getcapabilities and a modern CLI handshake workflow.Dec 15 2014, 7:15 PM
avivey mentioned this in D14400: Remove Certificate page.Nov 4 2015, 3:28 AM
avivey mentioned this in rP18f0371b71fb: Remove Certificate page.Nov 4 2015, 6:35 AM

Revision Contents
Changeset List

PathSize
scripts/
19 lines
src/
workflow/
108 lines
28 lines

Diff 26382

View Options

scripts/arcanist.php

Loading...
View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility