Page MenuHomePhabricator

Make ConduitCall always local/in-process
ClosedPublic

Authored by epriestley on Dec 10 2014, 6:16 PM.
Tags
None
Referenced Files
F15509904: D10959.diff
Wed, Apr 16, 5:21 PM
F15509143: D10959.diff
Wed, Apr 16, 10:02 AM
F15430902: D10959.id26315.diff
Mon, Mar 24, 9:32 AM
F15419209: D10959.id26314.diff
Fri, Mar 21, 4:28 AM
F15416313: D10959.id26315.diff
Thu, Mar 20, 10:29 AM
F15414835: D10959.id26325.diff
Thu, Mar 20, 2:44 AM
F15401708: D10959.id26315.diff
Mar 17 2025, 6:56 PM
F15401325: D10959.id.diff
Mar 17 2025, 5:03 PM
Subscribers

Details

Summary

Ref T2783. ConduitCall currently has logic to pick a random remote server, but this is ultimately not appropriate: we always want to send requests to a specific server. For example, we want to send repository requests to a server which has that repository locally. The repository tier is not homogenous, so we can't do this below the call level.

Make ConduitCall always-local; logic above it will select ConduitCall for an in-process request or do service selection for an off-host request via ConduitClient.

Test Plan
  • Browsed some pages using ConduitCall, everything worked.
  • Grepped for removed stuff.

Diff Detail

Repository
rP Phabricator
Branch
abind1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3214
Build 3220: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make ConduitCall always local/in-process.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Found more stuff to remove.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2014, 9:29 PM
This revision was automatically updated to reflect the committed changes.