Page MenuHomePhabricator

Make ConduitCall always local/in-process
ClosedPublic

Authored by epriestley on Dec 10 2014, 6:16 PM.
Tags
None
Referenced Files
F13143236: D10959.diff
Fri, May 3, 7:20 AM
Unknown Object (File)
Fri, Apr 26, 4:29 PM
Unknown Object (File)
Fri, Apr 26, 4:29 PM
Unknown Object (File)
Fri, Apr 26, 4:29 PM
Unknown Object (File)
Fri, Apr 26, 4:29 PM
Unknown Object (File)
Thu, Apr 25, 1:13 PM
Unknown Object (File)
Thu, Apr 25, 1:28 AM
Unknown Object (File)
Tue, Apr 16, 6:15 PM
Subscribers

Details

Summary

Ref T2783. ConduitCall currently has logic to pick a random remote server, but this is ultimately not appropriate: we always want to send requests to a specific server. For example, we want to send repository requests to a server which has that repository locally. The repository tier is not homogenous, so we can't do this below the call level.

Make ConduitCall always-local; logic above it will select ConduitCall for an in-process request or do service selection for an off-host request via ConduitClient.

Test Plan
  • Browsed some pages using ConduitCall, everything worked.
  • Grepped for removed stuff.

Diff Detail

Repository
rP Phabricator
Branch
abind1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3213
Build 3219: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make ConduitCall always local/in-process.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Found more stuff to remove.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2014, 9:29 PM
This revision was automatically updated to reflect the committed changes.