Page MenuHomePhabricator

Don't keep garbage in DBMS when removing repository.
Needs RevisionPublic

Authored by onovy on Nov 30 2014, 1:08 PM.
Tags
None
Referenced Files
F13228732: D10908.diff
Mon, May 20, 11:37 AM
Unknown Object (File)
Sat, Apr 27, 2:24 AM
Unknown Object (File)
Apr 19 2024, 11:45 AM
Unknown Object (File)
Jan 10 2024, 2:40 PM
Unknown Object (File)
Dec 23 2023, 8:22 PM
Unknown Object (File)
Dec 22 2023, 1:08 PM
Unknown Object (File)
Dec 20 2023, 1:33 AM
Unknown Object (File)
Dec 16 2023, 4:10 PM

Details

Summary

When removing repository, Phabricator keeps useless records in some tables
in DBMS. This patch removes this records too.

Test Plan
  • Create new repository
  • Add some commits to this repository
  • Remove this repository using CLI
  • Look in DB phabricator_repository in tables: repository_pushevent repository_pushlog repository_statusmessage repository_commit
  • Useless records for removed repository should not be there

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 3148
Build 3154: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestURIGeneration
0 mstestBranchFilter
0 mstestFilterMercurialDebugOutput
0 mstestRepositoryURIProtocols
0 mstestSubversionPathInfo

Event Timeline

onovy retitled this revision from to Don't keep garbage in DBMS when removing repository..
onovy updated this object.
onovy edited the test plan for this revision. (Show Details)
onovy added a reviewer: epriestley.
onovy edited edge metadata.

New unit testing.

This revision now requires changes to proceed.Nov 23 2015, 4:02 PM