Page MenuHomePhabricator
Differential D10905

Monospaced preferences now display in Remarkup areas
ClosedPublic
Actions

Authored by chad on Nov 27 2014, 4:46 AM.
Tags
None
Referenced Files
F14389641: D10905.diff
Sat, Dec 21, 5:45 PM
Unknown Object (File)
Thu, Dec 19, 4:25 PM
Unknown Object (File)
Thu, Dec 19, 1:49 PM
Unknown Object (File)
Wed, Dec 18, 12:44 AM
Unknown Object (File)
Sun, Dec 15, 5:00 PM
Unknown Object (File)
Fri, Dec 6, 4:52 AM
Unknown Object (File)
Thu, Dec 5, 8:42 PM
Unknown Object (File)
Wed, Nov 27, 9:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T6109: Remarkup monospaced text does not have "Monospaced Font" display setting applied
T6654: Code blocks not displayed in monospaced fashion in Firefox
Commits
Restricted Diffusion Commit
rP48e90ca7d561: Monospaced preferences now display in Remarkup areas
Summary

Fixes T6109, Ref T6654. Correctly clobbers the Remarkup defaults.

Test Plan

Tested with Copperplate!

pasted_file (218×337 px, 22 KB)

Diff Detail

Repository
rP Phabricator
Branch
monospace
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3145
Build 3151: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26195.Nov 27 2014, 4:46 AM
chad retitled this revision from to Monospaced preferences now display in Remarkup areas.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added tasks: T6654: Code blocks not displayed in monospaced fashion in Firefox, T6109: Remarkup monospaced text does not have "Monospaced Font" display setting applied.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 27 2014, 4:46 AM
chad edited the test plan for this revision. (Show Details)Nov 27 2014, 4:47 AM
Harbormaster completed remote builds in B3145: Diff 26195.Nov 27 2014, 4:47 AM
chad edited the test plan for this revision. (Show Details)Nov 27 2014, 4:47 AM
epriestley accepted this revision.Nov 27 2014, 1:09 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 27 2014, 1:09 PM
Closed by commit rP48e90ca7d561: Monospaced preferences now display in Remarkup areas (authored by chad, committed by chad). · Explain WhyNov 27 2014, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
page/
5 lines

Diff 26195

View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
Phabricator · Built by Phacility