Page MenuHomePhabricator

Improve Drydock log search engine
ClosedPublic

Authored by hach-que on Nov 19 2014, 4:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:25 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 1:46 PM
Unknown Object (File)
Thu, Dec 19, 1:46 PM
Unknown Object (File)
Thu, Dec 19, 1:46 PM
Unknown Object (File)
Thu, Dec 19, 1:46 PM
Unknown Object (File)
Thu, Dec 19, 1:46 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Commits
Restricted Diffusion Commit
rP0d4f9363a0f2: Improve Drydock log search engine
Summary

Ref T2015. This allows searching based on blueprints, resources or leases when viewing the logs, which helps when searching for events that occured to a particular blueprint / resource / lease. Unlike the logs shown on the resource / lease pages, the search engine supports paging properly, which means it can be used to find entries in the past.

Test Plan

Used the Drydock log search page.

Diff Detail

Repository
rP Phabricator
Branch
test
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/drydock/query/DrydockLogSearchEngine.php:31XHP16TODO Comment
Unit
Test Failures
Build Status
Buildable 3109
Build 3115: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestCelerityMaps
0 mstestApplicationsInstalled
0 mstestEverythingImplemented
0 mstestLibraryMap
0 mstestRejectMySQLNonUTF8Queries

Event Timeline

hach-que retitled this revision from to Improve Drydock log search engine.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.

One inline about the column type.

src/applications/drydock/query/DrydockLogSearchEngine.php
31–33

You can remove "I don't believe...", this assertion correct.

src/applications/drydock/storage/DrydockBlueprint.php
42

Can this be sort255? Do you need blueprint names longer than 255 characters? (sort is a LONGTEXT.)

src/applications/drydock/storage/DrydockBlueprint.php
42

Ah I didn't realise sort255 existed. I'll change that back.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2014, 7:10 PM

Oh damn :(

It turns out this does rely on previous patches. It's based on the log table having blueprintPHID in it, which upstream doesn't actually have yet.

I'll see if I can track down what patch I introduced that in and extract it if needed.

Looks like it's D10506. I'll rip out the blueprint PHID adding stuff from that and submit it as a separate diff so these can be landed.

Remove blueprint PHID dependency

This revision was automatically updated to reflect the committed changes.