Ref T2015. This allows searching based on blueprints, resources or leases when viewing the logs, which helps when searching for events that occured to a particular blueprint / resource / lease. Unlike the logs shown on the resource / lease pages, the search engine supports paging properly, which means it can be used to find entries in the past.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T2015: Implement Drydock
- Commits
- Restricted Diffusion Commit
rP0d4f9363a0f2: Improve Drydock log search engine
Used the Drydock log search page.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- live-master
- Lint
Lint Passed Severity Location Code Message Advice src/applications/drydock/query/DrydockLogSearchEngine.php:31 XHP16 TODO Comment - Unit
Test Failures - Build Status
Buildable 3960 Build 3973: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 3,148 ms | PhabricatorLibraryTestCase::testMethodVisibility | |
| 1,690 ms | PhabricatorCelerityTestCase::testCelerityMaps | |
| 52 ms | PhabricatorConduitTestCase::testConduitMethods | |
| 0 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled | |
| 11 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries | |
| View Full Test Results (1 Failed · 6 Passed) |
Event Timeline
Comment Actions
One inline about the column type.
| src/applications/drydock/query/DrydockLogSearchEngine.php | ||
|---|---|---|
| 31–33 | You can remove "I don't believe...", this assertion correct. | |
| src/applications/drydock/storage/DrydockBlueprint.php | ||
| 43 | Can this be sort255? Do you need blueprint names longer than 255 characters? (sort is a LONGTEXT.) | |
| src/applications/drydock/storage/DrydockBlueprint.php | ||
|---|---|---|
| 43 | Ah I didn't realise sort255 existed. I'll change that back. | |
Comment Actions
Oh damn :(
It turns out this does rely on previous patches. It's based on the log table having blueprintPHID in it, which upstream doesn't actually have yet.
I'll see if I can track down what patch I introduced that in and extract it if needed.
Comment Actions
Looks like it's D10506. I'll rip out the blueprint PHID adding stuff from that and submit it as a separate diff so these can be landed.