Page MenuHomePhabricator
Differential D10867

Search Typeahead - make exact matches show up first
ClosedPublic
Actions

Authored by btrahan on Nov 17 2014, 11:11 PM.
Tags
None
Referenced Files
F13996353: D10867.id26091.diff
Wed, Oct 23, 8:23 PM
F13996316: D10867.id26091.diff
Wed, Oct 23, 8:03 PM
F13996173: D10867.id26094.diff
Wed, Oct 23, 6:37 PM
F13996118: D10867.id26094.diff
Wed, Oct 23, 6:11 PM
F13989922: D10867.id26095.diff
Mon, Oct 21, 11:56 PM
F13985310: D10867.id26095.diff
Sun, Oct 20, 7:38 PM
F13976769: D10867.id26095.diff
Fri, Oct 18, 3:38 PM
F13976005: D10867.id26091.diff
Fri, Oct 18, 12:31 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6102: Improve typeahead behavior around exact matches
Commits
Restricted Diffusion Commit
rP81a13ed8bda8: Search Typeahead - make exact matches show up first
Summary

Fixes T6102. Give "priority" treatment to strings that are exact matches.

Test Plan

made a bunch of projects with the word project in them including "Project". before patch, "Project" wouldn't even show up if I typed "Project" - now its the second result right after the application "Projects".

Screen_Shot_2014-11-17_at_3.13.45_PM.png (1×2 px, 820 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26091.Nov 17 2014, 11:11 PM
btrahan added a task: T6102: Improve typeahead behavior around exact matches.
btrahan retitled this revision from to Search Typeahead - make exact matches show up first.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 17 2014, 11:11 PM
Harbormaster completed remote builds in B3076: Diff 26091.Nov 17 2014, 11:11 PM
btrahan added a comment.Nov 17 2014, 11:14 PM

Screen_Shot_2014-11-17_at_3.13.45_PM.png (1×2 px, 820 KB)

btrahan edited the test plan for this revision. (Show Details)Nov 17 2014, 11:14 PM
epriestley accepted this revision.Nov 17 2014, 11:28 PM
epriestley edited edge metadata.

Do we need toLowerCase()? I think we might already have called it on both parts (maybe only one part?) by the time we get here.

This revision is now accepted and ready to land.Nov 17 2014, 11:28 PM
btrahan added a comment.Nov 17 2014, 11:28 PM

I'll do some testing to try to figure it out...

btrahan updated this revision to Diff 26094.Nov 17 2014, 11:31 PM
btrahan edited edge metadata.

remove toLowerCase for both parts; they must be normalized by now in the stack

tested by searching for PROJECT, project, pRoJeCt, and PROJECT EVER... got the right results each time.

Harbormaster completed remote builds in B3077: Diff 26094.Nov 17 2014, 11:31 PM
Closed by commit rP81a13ed8bda8: Search Typeahead - make exact matches show up first (authored by btrahan, committed by btrahan). · Explain WhyNov 17 2014, 11:32 PM
This revision was automatically updated to reflect the committed changes.
btrahan mentioned this in D11305: Tokenizers - improve algorithm around exact matches..Jan 9 2015, 10:43 PM
btrahan mentioned this in rP49ee09be3f45: Tokenizers - improve algorithm around exact matches..Jan 9 2015, 10:54 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
webroot/
rsrc/
js/
core/
11 lines

Diff 26095

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...
Phabricator · Built by Phacility