Page MenuHomePhabricator
Differential D10864

Clean up Multirow Manager UI
ClosedPublic
Actions

Authored by chad on Nov 17 2014, 9:56 PM.
Tags
None
Referenced Files
F13275694: D10864.diff
Fri, May 31, 5:05 AM
F13244908: D10864.id26087.diff
Thu, May 23, 5:25 AM
F13222896: D10864.diff
Sun, May 19, 4:05 AM
F13183558: D10864.id26087.diff
Fri, May 10, 10:23 AM
Unknown Object (File)
Fri, May 3, 2:55 AM
Unknown Object (File)
Apr 29 2024, 2:35 PM
Unknown Object (File)
Apr 24 2024, 10:40 PM
Unknown Object (File)
Apr 11 2024, 7:37 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Orange Medal" token, awarded by epriestley."Haypence" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4234: Improve design of MultirowManager used for Herald rules and custom Policies
Commits
Restricted Diffusion Commit
rPe7b6d332e9af: Clean up Multirow Manager UI
Summary

Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways.

Test Plan

Test editing a policy and some herald rules. Stuff lines up better.

Screen_Shot_2014-11-17_at_1.53.45_PM.png (622×2 px, 87 KB)

Screen_Shot_2014-11-17_at_1.35.58_PM.png (972×1 px, 131 KB)

Diff Detail

Repository
rP Phabricator
Branch
phui-form-inset
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3073
Build 3079: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26087.Nov 17 2014, 9:56 PM
chad retitled this revision from to Clean up Multirow Manager UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T4234: Improve design of MultirowManager used for Herald rules and custom Policies.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 17 2014, 9:56 PM
chad edited the test plan for this revision. (Show Details)Nov 17 2014, 9:56 PM
Harbormaster completed remote builds in B3073: Diff 26087.Nov 17 2014, 9:57 PM
btrahan awarded a token.Nov 17 2014, 9:57 PM
epriestley accepted this revision.Nov 17 2014, 10:04 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2014, 10:04 PM
epriestley awarded a token.Nov 17 2014, 10:04 PM
Closed by commit rPe7b6d332e9af: Clean up Multirow Manager UI (authored by chad, committed by chad). · Explain WhyNov 17 2014, 10:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
webroot/
rsrc/
css/
application/
herald/
7 lines
policy/
6 lines
phui/
14 lines
js/
core/
6 lines

Diff 26087

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/herald/herald.css

Loading...
View Options

webroot/rsrc/css/application/policy/policy-edit.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/js/core/MultirowRowManager.js

Loading...
Phabricator · Built by Phacility