Page MenuHomePhabricator

Allow config get to work when db is not functional
ClosedPublic

Authored by skroll on Nov 14 2014, 4:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 1:44 PM
Unknown Object (File)
Thu, Dec 19, 1:44 PM
Unknown Object (File)
Thu, Dec 19, 1:44 PM
Unknown Object (File)
Thu, Dec 19, 1:44 PM
Unknown Object (File)
Wed, Dec 18, 11:46 PM
Unknown Object (File)
Fri, Dec 13, 2:30 AM
Unknown Object (File)
Sat, Dec 7, 11:53 AM
Unknown Object (File)
Sat, Dec 7, 9:53 AM
Subscribers
Tokens
"Like" token, awarded by chad.

Details

Summary

Fixes T6554.

Test Plan

Run bin/config get mysql.host when no db is functional. Should not get an exception, but should see:

{
  "config" : [
    {
      "key"       : "mysql.host",
      "source"    : "local",
      "value"     : null,
      "status"    : "unset",
      "errorInfo" : null
    },
    {
      "key"       : "mysql.host",
      "source"    : "database",
      "value"     : null,
      "status"    : "error",
      "errorInfo" : "Database source is not configured properly"
    }
  ]
}

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3048
Build 3054: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

skroll retitled this revision from to Allow config get to work when db is not functional.
skroll updated this object.
skroll edited the test plan for this revision. (Show Details)

I already did, or did it not associate it with my account?

EDIT: Signed it again.

epriestley added a reviewer: epriestley.

Looks like it's good now. Thanks!

This revision is now accepted and ready to land.Nov 14 2014, 5:11 PM
This revision was automatically updated to reflect the committed changes.