Page MenuHomePhabricator

bin/config should allow for retrieving local values even if database is not functional
Closed, ResolvedPublic

Description

Currently, if there is no configured database (or it is not functional), then bin/config get <key> will fail. This functionality is useful when automating local configuration settings (such as being able to check values before setting them) without manually parsing the local config file.

There already seems to be a mechanism in PhabricatorConfigManagementGetWorkflow for handling database exceptions and returning an error in the results, except for when instantiating PhabricatorConfigDatabaseSource fails. Simply moving the instantiation of PhabricatorConfigDatabaseSource into the try block solves this issue.

Revisions and Commits

Restricted Differential Revision

Event Timeline

skroll raised the priority of this task from to Needs Triage.
skroll updated the task description. (Show Details)
skroll added a subscriber: skroll.
skroll added a revision: Restricted Differential Revision.Nov 14 2014, 4:56 PM
epriestley added a commit: Restricted Diffusion Commit.

Closed by commit rP84f741f40851.