Page MenuHomePhabricator

Allow config get to work when db is not functional
ClosedPublic

Authored by skroll on Nov 14 2014, 4:56 PM.
Tags
None
Referenced Files
F15518540: D10851.id26050.diff
Sat, Apr 19, 2:20 PM
F15516964: D10851.id26049.diff
Fri, Apr 18, 10:40 PM
F15512073: D10851.id26049.diff
Thu, Apr 17, 7:48 AM
F15511631: D10851.id.diff
Thu, Apr 17, 3:46 AM
F15509179: D10851.diff
Wed, Apr 16, 10:27 AM
F15492437: D10851.id26050.diff
Sat, Apr 12, 2:24 PM
F15424944: D10851.id26049.diff
Mar 23 2025, 1:17 AM
F15409303: D10851.id26050.diff
Mar 19 2025, 4:05 AM
Subscribers
Tokens
"Like" token, awarded by chad.

Details

Summary

Fixes T6554.

Test Plan

Run bin/config get mysql.host when no db is functional. Should not get an exception, but should see:

{
  "config" : [
    {
      "key"       : "mysql.host",
      "source"    : "local",
      "value"     : null,
      "status"    : "unset",
      "errorInfo" : null
    },
    {
      "key"       : "mysql.host",
      "source"    : "database",
      "value"     : null,
      "status"    : "error",
      "errorInfo" : "Database source is not configured properly"
    }
  ]
}

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

skroll retitled this revision from to Allow config get to work when db is not functional.
skroll updated this object.
skroll edited the test plan for this revision. (Show Details)

I already did, or did it not associate it with my account?

EDIT: Signed it again.

epriestley added a reviewer: epriestley.

Looks like it's good now. Thanks!

This revision is now accepted and ready to land.Nov 14 2014, 5:11 PM
This revision was automatically updated to reflect the committed changes.