Differential D10827

Ref T6500, Duplicated tasks should be marked more visibly as duplicates
ClosedPublic
Actions

Authored by lpriestley on Nov 11 2014, 2:30 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6500: Duplicated tasks should be marked more visibly as duplicates

Commits

Restricted Diffusion Commit
rP95df7717c3e8: Ref T6500, Duplicated tasks should be marked more visibly as duplicates

Summary

When merging tasks, the corresponding transaction on the merged task should be black, and the transaction on the ultimate task should be green.

Test Plan

Create two tasks, merge one into the other, merged task transaction is black, the surviving task should show a green transaction.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 25985.Nov 11 2014, 2:30 AM

lpriestley retitled this revision from to Ref T6500, Duplicated tasks should be marked more visibly as duplicates.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 11 2014, 2:30 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B3008: Diff 25985.Nov 11 2014, 2:30 AM

I'd probably pick a new color to represent "merge" in general, since it's a different action than open.

src/applications/maniphest/storage/ManiphestTransaction.php
220	maybe pink or orange?

lpriestley added a task: T6500: Duplicated tasks should be marked more visibly as duplicates.Nov 11 2014, 3:36 AM

lpriestley added inline comments.Nov 11 2014, 3:39 AM

src/applications/maniphest/storage/ManiphestTransaction.php
220	Like that?

Changing from green to orange.

Harbormaster completed remote builds in B3009: Diff 25986.Nov 11 2014, 3:41 AM

I need to finish setting up a couple more things locally before I can actually pull this, but it looks good to me.

This revision is now accepted and ready to land.Nov 11 2014, 3:46 AM

I think the colors are switched. The 'Closed, Duplicate' task should be 'black' and the still open task should be 'orange'

And, looking more closely, we should also actually say 'closed' somewhere in the transaction copy.

chad closed this task as a duplicate of T1234

@epriestley?

The merge story is a little unclear that the task is closed.

Yeah, that makes sense to me.

And I forgot to give you @lpriestley's Chocolate Raspberry Jam yesterday. :(

Let's swap the colors, unless the constants are just confusing (it looked OK in person but maybe something got flipped since then) -- the closed task should be black.

And inline...

src/applications/maniphest/storage/ManiphestTransaction.php
599	Change this to @chad's copy or similar, "%s closed this task as a duplicate of %s.", to make the close more clear and explicit.
606	This one is fine as-is.