Page MenuHomePhabricator
Differential D10794

Break logo/name into replaceable parts
ClosedPublic
Actions

Authored by chad on Nov 6 2014, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 12:35 PM
Unknown Object (File)
Wed, Nov 20, 1:50 PM
Unknown Object (File)
Tue, Nov 19, 6:22 PM
Unknown Object (File)
Sun, Nov 17, 11:55 AM
Unknown Object (File)
Sat, Nov 16, 4:57 PM
Unknown Object (File)
Tue, Nov 12, 9:29 PM
Unknown Object (File)
Mon, Nov 11, 1:59 AM
Unknown Object (File)
Fri, Nov 8, 5:31 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4214: Allow installs to change or supplement the "Phabricator" icon
Commits
Restricted Diffusion Commit
rP3ea31c92b916: Break logo/name into replaceable parts
Summary

Ref T4214, this breaks the 'eye' out as a separate image 40px x 40px. We also now show the eye on mobile, as we have enough room for both currently.

Test Plan

Tested default and nightmaremoon colors, tested mobile, tablet and desktop layouts.

Diff Detail

Repository
rP Phabricator
Branch
logo-adjust
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2963
Build 2967: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25908.Nov 6 2014, 5:15 PM
chad retitled this revision from to Break logo/name into replaceable parts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 6 2014, 5:15 PM
Harbormaster completed remote builds in B2963: Diff 25908.Nov 6 2014, 5:15 PM
chad updated this revision to Diff 25909.Nov 6 2014, 5:16 PM
  • Limit hover to .device
Harbormaster completed remote builds in B2964: Diff 25909.Nov 6 2014, 5:17 PM
epriestley accepted this revision.Nov 6 2014, 5:21 PM
epriestley edited edge metadata.

Cool, this seems like a pretty clean approach. I can figure out a workflow to let installs swap it.

This revision is now accepted and ready to land.Nov 6 2014, 5:21 PM
chad added a comment.Nov 6 2014, 5:22 PM

This likely solves 75% of the requests, but for the remaining 25% I'd rather wait and be more aggressive with a full header re-design (for flags, spaces, etc).

Closed by commit rP3ea31c92b916: Break logo/name into replaceable parts (authored by chad, committed by chad). · Explain WhyNov 6 2014, 5:23 PM
This revision was automatically updated to reflect the committed changes.
• wasimsikder removed a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:00 AM
avivey added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:43 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
sprite/
manifest/
9 lines
menu_1x/
menu_2x/
src/
applications/
celerity/
9 lines
view/
page/
menu/
11 lines
webroot/
rsrc/
css/
application/
base/
30 lines
8 lines
image/

Diff 25908

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/manifest/menu.json

Loading...
View Options

resources/sprite/menu_1x/eye.png

Loading...
View Options

resources/sprite/menu_1x/logo.png

Loading...
View Options

resources/sprite/menu_2x/eye.png

Loading...
View Options

resources/sprite/menu_2x/logo.png

Loading...
View Options

src/applications/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
View Options

webroot/rsrc/css/sprite-menu.css

Loading...
View Options

webroot/rsrc/image/sprite-menu-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-menu.png

Loading...
Phabricator · Built by Phacility