Page MenuHomePhabricator

Break logo/name into replaceable parts
ClosedPublic

Authored by chad on Nov 6 2014, 5:15 PM.
Tags
None
Referenced Files
F14038764: D10794.id25910.diff
Mon, Nov 11, 1:59 AM
F14028891: D10794.diff
Fri, Nov 8, 5:31 PM
F14027085: D10794.diff
Fri, Nov 8, 5:05 AM
F14011588: D10794.id25910.diff
Fri, Nov 1, 3:15 AM
F14005880: D10794.id.diff
Sun, Oct 27, 9:16 PM
F14001288: D10794.id.diff
Fri, Oct 25, 6:03 AM
F13967155: D10794.id25910.diff
Wed, Oct 16, 12:04 PM
F13964683: D10794.diff
Tue, Oct 15, 9:17 PM
Subscribers

Details

Summary

Ref T4214, this breaks the 'eye' out as a separate image 40px x 40px. We also now show the eye on mobile, as we have enough room for both currently.

Test Plan

Tested default and nightmaremoon colors, tested mobile, tablet and desktop layouts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Break logo/name into replaceable parts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
  • Limit hover to .device
epriestley edited edge metadata.

Cool, this seems like a pretty clean approach. I can figure out a workflow to let installs swap it.

This revision is now accepted and ready to land.Nov 6 2014, 5:21 PM

This likely solves 75% of the requests, but for the remaining 25% I'd rather wait and be more aggressive with a full header re-design (for flags, spaces, etc).

This revision was automatically updated to reflect the committed changes.