Page MenuHomePhabricator

[drydock/core] Support different shells in Harbormaster / Drydock
AbandonedPublic

Authored by hach-que on Sep 25 2014, 2:19 AM.
Tags
None
Referenced Files
F13808003: D10556.diff
Mon, Sep 16, 7:51 PM
Unknown Object (File)
Sat, Sep 14, 9:04 PM
Unknown Object (File)
Thu, Sep 12, 6:27 AM
Unknown Object (File)
Thu, Sep 12, 6:27 AM
Unknown Object (File)
Thu, Sep 12, 6:27 AM
Unknown Object (File)
Wed, Sep 11, 4:06 AM
Unknown Object (File)
Thu, Sep 5, 9:59 AM
Unknown Object (File)
Mon, Aug 26, 1:18 PM

Details

Summary

Ref T2015. Ref T1049. This allows users to select different shells when executing commands via Harbormaster. Primarily this is to address an issue where running native commands under Powershell on Windows will swallow up the exit code, causing false positives when native commands fail. In order for native command exit codes to be reported correctly, they need to be run under "Windows Command Prompt".

Test Plan

Tested this behaviour locally with a build plan that runs commands under various shells.

Diff Detail

Repository
rP Phabricator
Branch
live-master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2962
Build 2966: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Support different shells in Harbormaster / Drydock.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

Depends on premature code.

This revision now requires changes to proceed.Aug 8 2015, 6:35 PM
hach-que retitled this revision from Support different shells in Harbormaster / Drydock to [drydock/core] Support different shells in Harbormaster / Drydock.Aug 24 2015, 12:06 PM
hach-que edited edge metadata.

I'm keeping this patched locally (it's essential if you ever upstream Windows support due to the cmd / PowerShell differences).