Ref T2015. Ref T1049. This allows users to select different shells when executing commands via Harbormaster. Primarily this is to address an issue where running native commands under Powershell on Windows will swallow up the exit code, causing false positives when native commands fail. In order for native command exit codes to be reported correctly, they need to be run under "Windows Command Prompt".
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T1049: Implement Harbormaster
T2015: Implement Drydock
Tested this behaviour locally with a build plan that runs commands under various shells.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hachque-reconstructed
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7770 Build 8572: [Placeholder Plan] Wait for 30 Seconds Build 8571: arc lint + arc unit
Event Timeline
Comment Actions
I'm keeping this patched locally (it's essential if you ever upstream Windows support due to the cmd / PowerShell differences).