Page MenuHomePhabricator

Phriction - move delete to modern editor + transactions
ClosedPublic

Authored by btrahan on Oct 30 2014, 4:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 12:08 PM
Unknown Object (File)
Fri, Mar 8, 1:46 PM
Unknown Object (File)
Fri, Mar 8, 10:58 AM
Unknown Object (File)
Tue, Mar 5, 6:29 PM
Unknown Object (File)
Feb 14 2024, 11:06 PM
Unknown Object (File)
Feb 8 2024, 8:44 AM
Unknown Object (File)
Feb 3 2024, 1:12 AM
Unknown Object (File)
Jan 22 2024, 10:57 PM

Details

Summary

Ref T4029. Much like D10756 this does the bare minimum to get things in there. I have a sticky with "TODOs" about moving the error-checking business logic into the editor in both cases.

Up next - move actions...

Test Plan

deleted a document and it worked! verified proper feed story.

Diff Detail

Repository
rP Phabricator
Branch
T4029p2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2915
Build 2919: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Phriction - move delete to modern editor + transactions.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
shadowhand added inline comments.
src/applications/phriction/controller/PhrictionDeleteController.php
36–38

if this is meant to be PSR style, the ); needs to be on a new line

src/applications/phriction/editor/PhrictionTransactionEditor.php
358–364

thumbsup

src/applications/phriction/storage/PhrictionTransaction.php
140

i kind of like the semantics of the fa-close alias, but not sure if that would be inconsistent with other TYPE_DELETEs.

this is the actual diff; I haven't done a branch of a branch in awhile and I forget my arc workflow

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phriction/storage/PhrictionTransaction.php
92–93

This seems more important than a title change? Maybe?

This revision is now accepted and ready to land.Oct 31 2014, 11:32 PM
This revision was automatically updated to reflect the committed changes.