Fix Phame handling of `$request`
ClosedPublic
Actions

Authored by epriestley on Oct 24 2014, 3:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 2:53 AM

	Unknown Object (File)
	Thu, May 2, 1:54 AM

	Unknown Object (File)
	Mon, Apr 29, 2:33 PM

	Unknown Object (File)
	Fri, Apr 26, 4:20 PM

	Unknown Object (File)
	Wed, Apr 24, 10:39 PM

	Unknown Object (File)
	Thu, Apr 11, 7:36 AM

	Unknown Object (File)
	Apr 5 2024, 1:10 PM

	Unknown Object (File)
	Mar 25 2024, 1:50 PM

View All Files

Subscribers

epriestley

Tokens

"Piece of Eight" token, awarded by btrahan.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6386: Phame is broken in HEAD

Commits

Restricted Diffusion Commit
rPa4b281aa2916: Fix Phame handling of `$request`

Summary

Fixes T6386. I missed this callsite in D10698.

Test Plan

Loaded local domained blog, no fatal.

Diff Detail

Repository

rP Phabricator

Branch

fixphame

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2887
Build 2891: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25791.Oct 24 2014, 3:31 PM

epriestley retitled this revision from to Fix Phame handling of `$request`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T6386: Phame is broken in HEAD.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 24 2014, 3:31 PM

Harbormaster completed remote builds in B2887: Diff 25791.Oct 24 2014, 3:31 PM

chad accepted this revision.Oct 24 2014, 4:01 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 24 2014, 4:01 PM

Closed by commit rPa4b281aa2916: Fix Phame handling of `$request` (authored by epriestley, committed by epriestley). · Explain WhyOct 24 2014, 4:02 PM

This revision was automatically updated to reflect the committed changes.

btrahan awarded a token.Oct 24 2014, 9:55 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

storage/

PhameBlog.php

3 lines

Diff 25791

View Options

src/applications/phame/storage/PhameBlog.php

Fix Phame handling of `$request`ClosedPublicActions