Page MenuHomePhabricator

Phame is broken in HEAD
Closed, ResolvedPublic

Description

Currently, Phame seems busted after an update to the latest HEAD. We were at rPee8004ab4d7db0e51ca85e7a17d31a08947ab341 before, and after updating to rP1120c465e480f503686ab503e2cf1e1f1b6cf16d, our Phame instance (at https://blog.haskell.org) now throws:

Class PhameBasicTemplateBlogSkin does not have a constructor, so you cannot pass any constructor arguments

With the logs:

2014/10/24 01:24:36 [error] 11802#0: *556 FastCGI sent in stderr: "PHP message: [2014-10-23 20:24:36] EXCEPTION: (ReflectionException) Class PhameBasicTemplateBlogSkin does not have a constructor, so you cannot pass any constructor arguments at [<phutil>/src/utils/utils.php:662]
PHP message:   #0 ReflectionClass::newInstanceArgs(array) called at [<phutil>/src/utils/utils.php:662]
PHP message:   #1 newv(string, array) called at [<phabricator>/src/applications/phame/storage/PhameBlog.php:75]
PHP message:   #2 PhameBlog::getSkinRenderer(AphrontRequest) called at [<phabricator>/src/applications/phame/controller/blog/PhameBlogLiveController.php:62]
PHP message:   #3 PhameBlogLiveController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
PHP message:   #4 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/webroot/index.php:103]" while reading response header from upstream, client: 173.245.50.164, server: phabricator.haskell.org, request: "GET / HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "blog.haskell.org"

We have a custom theme (oblivious-haskell-theme), but it seems unrelated. I imagine this is due to some of the Aphront/Celerity changes recently.

Revisions and Commits