Page MenuHomePhabricator
Differential D10742

Support arbitrary start numbers for ordered lists in remarkup
ClosedPublic
Actions

Authored by richardvanvelzen on Oct 23 2014, 7:24 PM.
Tags
None
Referenced Files
F13243291: D10742.diff
Thu, May 23, 3:41 AM
F13221642: D10742.diff
Sun, May 19, 2:56 AM
F13204097: D10742.diff
Wed, May 15, 12:20 AM
F13186883: D10742.diff
Sat, May 11, 4:11 AM
F13183328: D10742.id25786.diff
Fri, May 10, 8:22 AM
Unknown Object (File)
Tue, May 7, 7:15 AM
Unknown Object (File)
Fri, May 3, 5:35 AM
Unknown Object (File)
Thu, Apr 25, 12:56 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
• Thirtyate
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6377: [remarkup] Allow specifying start number of an ordered list
Commits
rPHU0db4b149c4e0: Support arbitrary start numbers for ordered lists in remarkup
Summary

Fixes T6377.

Test Plan

Unit tests, mostly. Also checked a local install to see if this felt sensible.

Diff Detail

Repository
rPHU libphutil
Branch
arbitrary-start
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2884
Build 2888: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

richardvanvelzen updated this revision to Diff 25786.Oct 23 2014, 7:24 PM
richardvanvelzen retitled this revision from to Support arbitrary start numbers for ordered lists in remarkup.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added reviewers: epriestley, • Thirtyate.
richardvanvelzen added a task: T6377: [remarkup] Allow specifying start number of an ordered list.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 23 2014, 7:24 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
Harbormaster completed remote builds in B2884: Diff 25786.Oct 23 2014, 7:25 PM
epriestley accepted this revision.Oct 23 2014, 7:28 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Oct 23 2014, 7:28 PM
Closed by commit rPHU0db4b149c4e0: Support arbitrary start numbers for ordered lists in remarkup (authored by richardvanvelzen, committed by epriestley). · Explain WhyOct 23 2014, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
20 lines
remarkup/
blockrule/
38 lines

Diff 25786

View Options

src/markup/engine/__tests__/remarkup/ordered-list-with-numbers.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupListBlockRule.php

Loading...
Phabricator · Built by Phacility