Differential D10656

Fix `LINT_KEYWORD_CASING` for `class` keyword
ClosedPublic
Actions

Authored by joshuaspence on Oct 7 2014, 10:28 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC8547a2592877: Fix `LINT_KEYWORD_CASING` for `class` keyword

Summary

D10653 didn't quite cut it.

Test Plan

Tested on a real file.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2770
Build 2774: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25593.Oct 7 2014, 10:28 PM

joshuaspence retitled this revision from to Fix `LINT_KEYWORD_CASING` for `class` keyword.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 7 2014, 10:28 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B2770: Diff 25593.Oct 7 2014, 10:29 PM

epriestley accepted this revision.Oct 7 2014, 10:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 7 2014, 10:29 PM

Closed by commit rARC8547a2592877: Fix `LINT_KEYWORD_CASING` for `class` keyword (authored by joshuaspence, committed by joshuaspence).Oct 7 2014, 10:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

5 lines

Diff 25593

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Fix `LINT_KEYWORD_CASING` for `class` keywordClosedPublicActions