Differential D10547

Support both WinRM and SSH for Windows
AbandonedPublic
Actions

Authored by hach-que on Sep 24 2014, 4:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jun 29 2026, 11:01 AM

	Unknown Object (File)
	Jun 25 2026, 1:57 PM

	Unknown Object (File)
	Jun 25 2026, 1:57 PM

	Unknown Object (File)
	Jun 23 2026, 4:21 PM

	Unknown Object (File)
	Jun 22 2026, 4:59 AM

	Unknown Object (File)
	Jun 22 2026, 4:59 AM

	Unknown Object (File)
	Apr 21 2026, 1:49 PM

	Unknown Object (File)
	Apr 11 2026, 12:03 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Summary

Ref T2015. This is similar to D10495 except that it is based on the EC2-related diffs and supports both SSH and WinRM for connecting to Windows machines.

Test Plan

Allocated a machine over WinRM and saw it run a build successfully.

Diff Detail

Repository

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/applications/drydock/blueprint/windows/WindowsZeroConf.php:12	TXT6	Trailing Whitespace
Advice	src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php:995	XHP48	Array Separator
Advice	src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php:1003	XHP48	Array Separator
Advice	src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php:1064	XHP48	Array Separator
Advice	src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php:1064	XHP48	Array Separator
Advice	src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php:1071	XHP48	Array Separator
Advice	src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php:1119	XHP48	Array Separator

Unit

Tests Passed

Build Status

Buildable 2637
Build 2641: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25334.Sep 24 2014, 4:34 AM

hach-que retitled this revision from to Support both WinRM and SSH for Windows.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 24 2014, 4:34 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2621: Diff 25334.Sep 24 2014, 4:35 AM

Fix missing parameter

Harbormaster completed remote builds in B2637: Diff 25366.Sep 25 2014, 4:32 AM

hach-que mentioned this in D10495: [drydock/core] Use WinRM instead of SSH for Windows hosts.Sep 25 2014, 8:34 AM

Rebase

Harbormaster completed remote builds in B2961: Diff 25906.Nov 6 2014, 6:29 AM

joshuaspence mentioned this in T6853: "Open Revisions Affecting These Files" should weight severity of changes.Jan 2 2015, 10:14 PM

Rebase

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 4:12 AM

Abandoning this since D10495 is a much better way forward.

Revision Contents
Changeset List

Path

Size

resources/

windows/

	sshzeroconf.ps1
	zeroconf.ps1

113 lines

winrmzeroconf.ps1

32 lines

src/

__phutil_library_map__.php

4 lines

applications/

drydock/

blueprint/

DrydockAmazonEC2HostBlueprintImplementation.php

129 lines

DrydockPreallocatedHostBlueprintImplementation.php

26 lines

windows/

WindowsZeroConf.php

79 lines

check/

DrydockSetupCheckWinRM.php

41 lines

interface/

command/

DrydockWinRMCommandInterface.php

76 lines

Diff 25366

resources/windows/sshzeroconf.ps1

Loading...

resources/windows/winrmzeroconf.ps1

Loading...

resources/windows/zeroconf.ps1

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/windows/WindowsZeroConf.php

Loading...

src/applications/drydock/check/DrydockSetupCheckWinRM.php

Loading...

src/applications/drydock/interface/command/DrydockWinRMCommandInterface.php

Loading...