Page MenuHomePhabricator
Differential D10534

Add a `getEndLineNumber` method to the `AASTNode` class
ClosedPublic
Actions

Authored by joshuaspence on Sep 21 2014, 10:12 PM.
Tags
None
Referenced Files
F13993459: D10534.id25310.diff
Tue, Oct 22, 10:59 PM
F13978755: D10534.diff
Sat, Oct 19, 12:48 AM
F13969740: D10534.diff
Oct 17 2024, 3:41 AM
Unknown Object (File)
Sep 17 2024, 5:46 AM
Unknown Object (File)
Sep 15 2024, 8:26 AM
Unknown Object (File)
Aug 26 2024, 7:22 AM
Unknown Object (File)
Aug 25 2024, 2:11 PM
Unknown Object (File)
Aug 20 2024, 1:23 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU8b30cbd0faff: Add a `getEndLineNumber` method to the `AASTNode` class
Summary

Adds a getEndLineNumber method to the AASTNode class. This method supplements the getLineNumber method, providing the ending line number for a given node. This feels a little awkward, but it makes D10535 a little nicer.

Test Plan

See D10535.

Diff Detail

Repository
rPHU libphutil
Branch
aastnodelen
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2601
Build 2605: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25310.Sep 21 2014, 10:12 PM
joshuaspence retitled this revision from to Add a `getEndLineNumber` method to the `AASTNode` class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 21 2014, 10:12 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2601: Diff 25310.Sep 21 2014, 10:13 PM
joshuaspence mentioned this in D10535: Add a linter rule for array separators.Sep 22 2014, 8:41 AM
joshuaspence updated this object.Sep 22 2014, 8:45 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
epriestley accepted this revision.Sep 24 2014, 8:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2014, 8:58 PM
Closed by commit rPHU8b30cbd0faff: Add a `getEndLineNumber` method to the `AASTNode` class (authored by joshuaspence, committed by joshuaspence).Sep 24 2014, 9:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
aast/
api/
15 lines

Diff 25310

View Options

src/parser/aast/api/AASTNode.php

Loading...
Phabricator · Built by Phacility