Page MenuHomePhabricator

Transactions - hide "mentioned in X" story if you can't see X
ClosedPublic

Authored by btrahan on Sep 12 2014, 5:51 PM.
Tags
None
Referenced Files
F15575017: D10488.id25211.diff
Tue, May 6, 4:35 AM
F15534908: D10488.id25239.diff
Thu, Apr 24, 2:38 AM
F15530145: D10488.id25211.diff
Wed, Apr 23, 2:08 AM
F15529355: D10488.id25239.diff
Tue, Apr 22, 6:57 PM
F15526140: D10488.id.diff
Mon, Apr 21, 7:34 PM
F15523517: D10488.id25211.diff
Mon, Apr 21, 1:52 AM
F15523502: D10488.diff
Mon, Apr 21, 1:46 AM
F15521500: D10488.diff
Sun, Apr 20, 2:50 PM
Subscribers

Details

Summary

...also re-jiggers all the anchor stuff to use $xaction ID. This seemed like the simplest way once I got in the code, as well as having nice properties for if / when we want to re-add some ajax stuff since the ID is a pretty solid piece of data to key off. Fixes T6083.

Test Plan

mentioned DX in private DX+1. Could see on DX the mention as me and not as the other user. For transactions, I left a comment on Paste and it worked, and I edited an existing transaction and it worked.

Diff Detail

Repository
rP Phabricator
Branch
T6083
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2527
Build 2531: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - hide "mentioned in X" story if you can't see X.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

It sucks that this breaks existing anchors and that we get not-so-nice anchors going forward, but I agree that this is probably the best approach in the long term.

This revision is now accepted and ready to land.Sep 14 2014, 1:31 PM

T4712 seems like it makes doing this a must.

This revision was automatically updated to reflect the committed changes.