...also re-jiggers all the anchor stuff to use $xaction ID. This seemed like the simplest way once I got in the code, as well as having nice properties for if / when we want to re-add some ajax stuff since the ID is a pretty solid piece of data to key off. Fixes T6083.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6083: Don't generate mentions from Conpherence threads
- Commits
- Restricted Diffusion Commit
rP444ced16d983: Transactions - hide "mentioned in X" story if you can't see X
mentioned DX in private DX+1. Could see on DX the mention as me and not as the other user. For transactions, I left a comment on Paste and it worked, and I edited an existing transaction and it worked.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T6083
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2527 Build 2531: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
It sucks that this breaks existing anchors and that we get not-so-nice anchors going forward, but I agree that this is probably the best approach in the long term.