Page MenuHomePhabricator

Transactions - hide "mentioned in X" story if you can't see X

Authored by btrahan on Sep 12 2014, 5:51 PM.
Referenced Files
F12197231: D10488.id25211.diff
Wed, Sep 27, 12:59 PM
F12175064: D10488.diff
Sat, Sep 9, 5:58 PM
F12163343: D10488.diff
Wed, Sep 6, 9:26 PM
F12127535: D10488.diff
Aug 19 2023, 5:42 PM
Unknown Object (File)
Aug 16 2023, 7:08 PM
Unknown Object (File)
Jul 23 2023, 6:20 PM
Unknown Object (File)
Jul 23 2023, 5:11 AM
Unknown Object (File)
Jul 20 2023, 12:11 PM



...also re-jiggers all the anchor stuff to use $xaction ID. This seemed like the simplest way once I got in the code, as well as having nice properties for if / when we want to re-add some ajax stuff since the ID is a pretty solid piece of data to key off. Fixes T6083.

Test Plan

mentioned DX in private DX+1. Could see on DX the mention as me and not as the other user. For transactions, I left a comment on Paste and it worked, and I edited an existing transaction and it worked.

Diff Detail

rP Phabricator
Lint Passed
No Test Coverage
Build Status
Buildable 2527
Build 2531: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - hide "mentioned in X" story if you can't see X.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

It sucks that this breaks existing anchors and that we get not-so-nice anchors going forward, but I agree that this is probably the best approach in the long term.

This revision is now accepted and ready to land.Sep 14 2014, 1:31 PM

T4712 seems like it makes doing this a must.

This revision was automatically updated to reflect the committed changes.