Differential D10474

Add a bunch of additional test cases for `ArcanistTextLinter`
ClosedPublic
Actions

Authored by joshuaspence on Sep 11 2014, 12:37 PM.

Tags

None

Referenced Files

	F15532042: D10474.id25202.diff
	Wed, Apr 23, 2:16 PM

	F15502452: D10474.id25186.diff
	Mon, Apr 14, 1:02 AM

	F15489089: D10474.id25202.diff
	Fri, Apr 11, 5:58 AM

	F15489088: D10474.id25187.diff
	Fri, Apr 11, 5:58 AM

	F15489087: D10474.id25186.diff
	Fri, Apr 11, 5:58 AM

	F15485903: D10474.diff
	Thu, Apr 10, 3:25 AM

	F15393116: D10474.id25186.diff
	Mar 15 2025, 7:44 PM

	F15284232: D10474.id25202.diff
	Mar 4 2025, 9:27 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCf4fd7ad612a9: Add a bunch of additional test cases for `ArcanistTextLinter`

Summary

Self-explanatory, improve test coverage.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

Tests Passed

Build Status

Buildable 2511
Build 2515: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25186.Sep 11 2014, 12:37 PM

joshuaspence retitled this revision from to Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 11 2014, 12:37 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2510: Diff 25186.Sep 11 2014, 12:37 PM

epriestley accepted this revision.Sep 11 2014, 12:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 11 2014, 12:38 PM

joshuaspence retitled this revision from Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL` to Add a bunch of additional test cases for `ArcanistTextLinter`.Sep 11 2014, 12:54 PM

joshuaspence edited edge metadata.

Add a bunch of other test cases

I chucked a few extras in here

Harbormaster completed remote builds in B2511: Diff 25187.Sep 11 2014, 12:55 PM

epriestley accepted this revision.Sep 11 2014, 1:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 11 2014, 1:27 PM

joshuaspence retitled this revision from Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL` to Add a bunch of additional test cases for `ArcanistTextLinter`.Sep 11 2014, 1:43 PM

joshuaspence edited edge metadata.

Closed by commit rARCf4fd7ad612a9 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

text/

bad-charset.lint-test

3 lines

line-wrap.lint-test

6 lines

trailing-whitespace.lint-test

8 lines

Diff 25187

src/lint/linter/tests/text/bad-charset.lint-test

Loading...

src/lint/linter/tests/text/line-wrap.lint-test

Loading...

src/lint/linter/tests/text/trailing-whitespace.lint-test

Loading...