Page MenuHomePhabricator
Differential D10474

Add a bunch of additional test cases for `ArcanistTextLinter`
ClosedPublic
Actions

Authored by joshuaspence on Sep 11 2014, 12:37 PM.
Tags
None
Referenced Files
F14006070: D10474.id25186.diff
Mon, Oct 28, 12:36 AM
F14002040: D10474.diff
Fri, Oct 25, 2:31 PM
F13974832: D10474.id25186.diff
Fri, Oct 18, 7:34 AM
F13971461: D10474.id25187.diff
Thu, Oct 17, 1:31 PM
F13967497: D10474.id25202.diff
Wed, Oct 16, 1:58 PM
F13962744: D10474.id25187.diff
Tue, Oct 15, 12:04 PM
Unknown Object (File)
Oct 3 2024, 7:00 PM
Unknown Object (File)
Oct 3 2024, 2:34 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCf4fd7ad612a9: Add a bunch of additional test cases for `ArcanistTextLinter`
Summary

Self-explanatory, improve test coverage.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
No Lint Coverage
Unit
Tests Passed
Build Status
Buildable 2511
Build 2515: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25186.Sep 11 2014, 12:37 PM
joshuaspence retitled this revision from to Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 11 2014, 12:37 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2510: Diff 25186.Sep 11 2014, 12:37 PM
epriestley accepted this revision.Sep 11 2014, 12:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 11 2014, 12:38 PM
joshuaspence retitled this revision from Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL` to Add a bunch of additional test cases for `ArcanistTextLinter`.Sep 11 2014, 12:54 PM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 25187.Sep 11 2014, 12:54 PM
joshuaspence retitled this revision from Add a bunch of additional test cases for `ArcanistTextLinter` to Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL`.

Add a bunch of other test cases

joshuaspence requested a review of this revision.Sep 11 2014, 12:55 PM
joshuaspence edited edge metadata.

I chucked a few extras in here

Harbormaster completed remote builds in B2511: Diff 25187.Sep 11 2014, 12:55 PM
epriestley accepted this revision.Sep 11 2014, 1:27 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 11 2014, 1:27 PM
joshuaspence retitled this revision from Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL` to Add a bunch of additional test cases for `ArcanistTextLinter`.Sep 11 2014, 1:43 PM
joshuaspence edited edge metadata.
joshuaspence closed this revision.Sep 11 2014, 9:23 PM
joshuaspence updated this revision to Diff 25202.

Closed by commit rARCf4fd7ad612a9 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
text/
3 lines
6 lines
8 lines

Diff 25187

View Options

src/lint/linter/__tests__/text/bad-charset.lint-test

Loading...
View Options

src/lint/linter/__tests__/text/line-wrap.lint-test

Loading...
View Options

src/lint/linter/__tests__/text/trailing-whitespace.lint-test

Loading...
Phabricator · Built by Phacility