Fixes T6059.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6059: Prevent objects from mentioning themselves
- Commits
- Restricted Diffusion Commit
rP13834f140617: Transactions - don't let objects mention themselves.
Made a comment on TX mentioning TX and TX+1. TX did not get a "mentioned" transaction while TX+1 did.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T6059
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2492 Build 2496: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php | ||
|---|---|---|
| 1214–1218 | I think $object->getPHID() is potentially null here (i.e., this code can run during creation of a new object, before the object is saved). We'll still get the right result since it's impossible to mention a nonexistent object, but adding an explicit if ($object->getPHID()) { ... } check might make this more clear some day down the line. | |