D10464.id25166.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D10464.id25166.diff
View Options

	diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	@@ -1199,18 +1199,23 @@
	}
	}

	- $objects = id(new PhabricatorObjectQuery())
	+ $mentioned_objects = id(new PhabricatorObjectQuery())
	->setViewer($this->getActor())
	->withPHIDs($mentioned_phids)
	->execute();

	$mentionable_phids = array();
	- foreach ($objects as $object) {
	- if ($object instanceof PhabricatorMentionableInterface) {
	- if (idx($this->getUnmentionablePHIDMap(), $object->getPHID())) {
	+ foreach ($mentioned_objects as $mentioned_object) {
	+ if ($mentioned_object instanceof PhabricatorMentionableInterface) {
	+ $mentioned_phid = $mentioned_object->getPHID();
	+ if (idx($this->getUnmentionablePHIDMap(), $mentioned_phid)) {
	continue;
	}
	- $mentionable_phids[$object->getPHID()] = $object->getPHID();
	+ // don't let objects mention themselves
	+ if ($object->getPHID() && $mentioned_phid == $object->getPHID()) {
	+ continue;
	+ }
	+ $mentionable_phids[$mentioned_phid] = $mentioned_phid;
	}
	}
	if ($mentionable_phids) {