Page MenuHomePhabricator

Transactions - don't let objects mention themselves.
ClosedPublic

Authored by btrahan on Sep 10 2014, 5:13 PM.
Tags
None
Referenced Files
F13259807: D10464.diff
Sun, May 26, 11:07 PM
F13259521: D10464.diff
Sun, May 26, 9:40 PM
F13210213: D10464.diff
Fri, May 17, 4:35 AM
F13194100: D10464.diff
Sun, May 12, 9:18 PM
F13177151: D10464.diff
Wed, May 8, 7:30 PM
Unknown Object (File)
Sat, May 4, 12:27 PM
Unknown Object (File)
Mon, Apr 29, 11:42 AM
Unknown Object (File)
Apr 24 2024, 9:48 PM
Subscribers

Details

Summary

Fixes T6059.

Test Plan

Made a comment on TX mentioning TX and TX+1. TX did not get a "mentioned" transaction while TX+1 did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Transactions - don't let objects mention themselves..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
1214–1218

I think $object->getPHID() is potentially null here (i.e., this code can run during creation of a new object, before the object is saved). We'll still get the right result since it's impossible to mention a nonexistent object, but adding an explicit if ($object->getPHID()) { ... } check might make this more clear some day down the line.

This revision is now accepted and ready to land.Sep 10 2014, 5:17 PM
btrahan edited edge metadata.
  • add $object->getPHID() && to if conditional for clarity
  • slap a comment on there too
btrahan updated this revision to Diff 25166.

Closed by commit rP13834f140617 (authored by @btrahan).