Page MenuHomePhabricator

Add a basic `arc unit` test binding to XHProf
ClosedPublic

Authored by epriestley on Aug 27 2014, 10:47 PM.
Tags
None
Referenced Files
F13163145: D10373.diff
Mon, May 6, 6:04 PM
Unknown Object (File)
Mar 14 2024, 3:53 PM
Unknown Object (File)
Mar 4 2024, 3:44 PM
Unknown Object (File)
Feb 17 2024, 10:20 AM
Unknown Object (File)
Feb 17 2024, 8:27 AM
Unknown Object (File)
Feb 15 2024, 1:10 PM
Unknown Object (File)
Feb 7 2024, 11:15 AM
Unknown Object (File)
Feb 1 2024, 2:50 AM
Subscribers

Details

Summary

This allows "arc unit" to more-or-less run the PHP extension tests in an approximately correct way.

Note that there are two test failures at HEAD on recent PHP, and they've been failing for some time.

Test Plan

Used arc unit to run some tests.

Diff Detail

Repository
rXPRF XHProf
Branch
arclint2
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 2375
Build 2379: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 msXHPRrof: Test Include File (load/run_init operations)
0 msXHPRrof: Test excluding call_user_func and similar functions
0 msXHPRrof: Basic Profiling Test
0 msXHPRrof: Basic Sampling Test
0 msXHPRrof: Sampling Mode Test
View Full Test Results (2 Failed · 6 Passed)

Event Timeline

epriestley retitled this revision from to Add a basic `arc unit` test binding to XHProf.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 28 2014, 5:10 PM
epriestley updated this revision to Diff 24982.

Closed by commit rXPRFa39446cf68f3 (authored by @epriestley).