Page MenuHomePhabricator
Differential D10373

Add a basic `arc unit` test binding to XHProf
ClosedPublic
Actions

Authored by epriestley on Aug 27 2014, 10:47 PM.

Details

Reviewers
btrahan
Commits
rXPRFa39446cf68f3: Add a basic `arc unit` test binding to XHProf
Summary

This allows "arc unit" to more-or-less run the PHP extension tests in an approximately correct way.

Note that there are two test failures at HEAD on recent PHP, and they've been failing for some time.

Test Plan

Used arc unit to run some tests.

Diff Detail

Repository
rXPRF XHProf
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24969.Aug 27 2014, 10:47 PM
epriestley retitled this revision from to Add a basic `arc unit` test binding to XHProf.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 27 2014, 10:47 PM
Harbormaster completed remote builds in B2375: Diff 24969.Aug 27 2014, 10:48 PM
btrahan accepted this revision.Aug 28 2014, 5:10 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 28 2014, 5:10 PM
epriestley closed this revision.Aug 28 2014, 5:34 PM
epriestley updated this revision to Diff 24982.

Closed by commit rXPRFa39446cf68f3 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
4 lines
2 lines
support/
libxhprof/
3 lines
18 lines
unit/
53 lines

Diff 24982

View Options

.arcconfig

Loading...
View Options

.gitignore

Loading...
View Options

support/libxhprof/__phutil_library_init__.php

Loading...
View Options

support/libxhprof/__phutil_library_map__.php

Loading...
View Options

support/libxhprof/unit/XHProfUnitTestEngine.php

Loading...
Phabricator · Built by Phacility