Page MenuHomePhabricator

Fix invalid redirect when issuing actions on buildables
ClosedPublic

Authored by hach-que on Aug 21 2014, 10:58 AM.
Tags
None
Referenced Files
F14024592: D10320.diff
Thu, Nov 7, 10:59 AM
F14004139: D10320.diff
Sat, Oct 26, 4:01 PM
F13970098: D10320.id.diff
Thu, Oct 17, 5:43 AM
Unknown Object (File)
Oct 2 2024, 4:11 AM
Unknown Object (File)
Sep 19 2024, 1:34 AM
Unknown Object (File)
Sep 19 2024, 1:26 AM
Unknown Object (File)
Sep 16 2024, 9:30 PM
Unknown Object (File)
Sep 4 2024, 10:43 AM
Subscribers

Details

Summary

Caught this with the new redirect validation logic. The $return_uri was being set as just B123 which is not valid. Prefixing it with / (like is done in HarbormasterBuildActionController already) gives the correct result of reloading the buildable's page.

Test Plan

Restarted all builds on a buildable, saw the page reload correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Fix invalid redirect when issuing actions on buildables.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, thanks!

This revision is now accepted and ready to land.Aug 21 2014, 11:23 AM
hach-que updated this revision to Diff 24843.

Closed by commit rP1ffa16aa6b38 (authored by @hach-que).