HomePhabricator

Fix invalid redirect when issuing actions on buildables

Description

Fix invalid redirect when issuing actions on buildables

Summary: Caught this with the new redirect validation logic. The $return_uri was being set as just B123 which is not valid. Prefixing it with / (like is done in HarbormasterBuildActionController already) gives the correct result of reloading the buildable's page.

Test Plan: Restarted all builds on a buildable, saw the page reload correctly.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10320

Details

Provenance
hach-queAuthored on
hach-quePushed on Aug 21 2014, 11:35 AM
Reviewer
Blessed Reviewers
Differential Revision
D10320: Fix invalid redirect when issuing actions on buildables
Parents
rPb7ad48aa50f4: Minor, also update PHPMailerLite to use quoted-printable
Branches
Unknown
Tags
Unknown

Event Timeline