Page MenuHomePhabricator

Fix invalid redirect when issuing actions on buildables
ClosedPublic

Authored by hach-que on Aug 21 2014, 10:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 11:56 PM
Unknown Object (File)
Thu, Dec 12, 1:05 PM
Unknown Object (File)
Fri, Dec 6, 3:34 PM
Unknown Object (File)
Thu, Dec 5, 7:58 AM
Unknown Object (File)
Wed, Nov 27, 5:54 AM
Unknown Object (File)
Sat, Nov 23, 4:36 AM
Unknown Object (File)
Nov 19 2024, 12:50 AM
Unknown Object (File)
Nov 15 2024, 8:13 AM
Subscribers

Details

Summary

Caught this with the new redirect validation logic. The $return_uri was being set as just B123 which is not valid. Prefixing it with / (like is done in HarbormasterBuildActionController already) gives the correct result of reloading the buildable's page.

Test Plan

Restarted all builds on a buildable, saw the page reload correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Fix invalid redirect when issuing actions on buildables.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, thanks!

This revision is now accepted and ready to land.Aug 21 2014, 11:23 AM
hach-que updated this revision to Diff 24843.

Closed by commit rP1ffa16aa6b38 (authored by @hach-que).