SSH Keys - allow viewer to download the private key
ClosedPublic
Actions

Authored by btrahan on Aug 20 2014, 8:34 PM.

Tags

None

Referenced Files

	F15478153: D10311.id24823.diff
	Mon, Apr 7, 8:48 PM

	F15445845: D10311.id24823.diff
	Thu, Mar 27, 4:12 PM

	F15441924: D10311.id24829.diff
	Wed, Mar 26, 8:35 PM

	F15438719: D10311.id24823.diff
	Wed, Mar 26, 3:01 AM

	F15435818: D10311.id24829.diff
	Tue, Mar 25, 10:25 AM

	F15434751: D10311.id.diff
	Tue, Mar 25, 5:08 AM

	F15432356: D10311.diff
	Mon, Mar 24, 5:44 PM

	F15429829: D10311.id.diff
	Mon, Mar 24, 4:31 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5931: Private keys are generating with excessively strict permissions

Commits

Restricted Diffusion Commit
rPd1c3915e3aa5: SSH Keys - allow viewer to download the private key

Summary

...cuz otherwise this is pretty pointless. Fixes T5931.

Test Plan

generated a key, downloaded the key. previously download failed.

Diff Detail

Repository

rP Phabricator

Branch

T5931

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2292
Build 2296: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24823.Aug 20 2014, 8:34 PM

btrahan added a task: T5931: Private keys are generating with excessively strict permissions.

btrahan retitled this revision from to SSH Keys - allow viewer to download the private key.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 20 2014, 8:34 PM

Harbormaster completed remote builds in B2292: Diff 24823.Aug 20 2014, 8:35 PM

epriestley accepted this revision.Aug 20 2014, 9:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 20 2014, 9:01 PM

Closed by commit rPd1c3915e3aa5 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorSettingsPanelSSHKeys.php

2 lines

Diff 24823

View Options

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

SSH Keys - allow viewer to download the private keyClosedPublicActions