SSH Keys - allow viewer to download the private key
ClosedPublic
Actions

Authored by btrahan on Aug 20 2014, 8:34 PM.

Tags

None

Referenced Files

	F14842396: D10311.id24829.diff
	Sat, Feb 1, 11:11 PM

	F14842320: D10311.id24823.diff
	Sat, Feb 1, 10:35 PM

	Unknown Object (File)
	Sun, Jan 26, 5:16 PM

	Unknown Object (File)
	Sun, Jan 26, 4:19 PM

	Unknown Object (File)
	Sun, Jan 26, 4:07 PM

	Unknown Object (File)
	Thu, Jan 23, 6:56 PM

	Unknown Object (File)
	Thu, Jan 23, 3:46 PM

	Unknown Object (File)
	Thu, Jan 23, 3:45 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5931: Private keys are generating with excessively strict permissions

Commits

Restricted Diffusion Commit
rPd1c3915e3aa5: SSH Keys - allow viewer to download the private key

Summary

...cuz otherwise this is pretty pointless. Fixes T5931.

Test Plan

generated a key, downloaded the key. previously download failed.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24823.Aug 20 2014, 8:34 PM

btrahan added a task: T5931: Private keys are generating with excessively strict permissions.

btrahan retitled this revision from to SSH Keys - allow viewer to download the private key.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 20 2014, 8:34 PM

Harbormaster completed remote builds in B2292: Diff 24823.Aug 20 2014, 8:35 PM

epriestley accepted this revision.Aug 20 2014, 9:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 20 2014, 9:01 PM

Closed by commit rPd1c3915e3aa5 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorSettingsPanelSSHKeys.php

2 lines

Diff 24829

View Options

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

SSH Keys - allow viewer to download the private keyClosedPublicActions