Send SMTP mail using quoted-printable encoding in all cases
ClosedPublic
Actions

Authored by epriestley on Aug 20 2014, 12:21 AM.

Details

Reviewers

btrahan
nickz
chad

Commits

Restricted Diffusion Commit
rP5449200972db: Send SMTP mail using quoted-printable encoding in all cases

Summary

See D10278. This works around a bug (?) in SendGrid, see http://stackoverflow.com/questions/6276181/extra-newlines-in-plain-text-emails-sent-via-sendgrid

Test Plan

@nickz confirmed this resolved his issue. See also D10278.

Diff Detail

Repository

rP Phabricator

Branch

quotedprintable

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2284
Build 2288: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24810.Aug 20 2014, 12:21 AM

epriestley retitled this revision from to Send SMTP mail using quoted-printable encoding in all cases.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: nickz, btrahan, chad.

epriestley added a subscriber: nickz.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 20 2014, 12:21 AM

Harbormaster completed remote builds in B2284: Diff 24810.Aug 20 2014, 12:22 AM

whatcouldgowrong

This revision is now accepted and ready to land.Aug 20 2014, 12:25 AM

Closed by commit rP5449200972db (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

adapter/

PhabricatorMailImplementationPHPMailerAdapter.php

5 lines

Diff 24810

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerAdapter.php

Send SMTP mail using quoted-printable encoding in all casesClosedPublicActions